[ 
https://issues.apache.org/jira/browse/PHOENIX-5123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761060#comment-16761060
 ] 

Andrew Purtell commented on PHOENIX-5123:
-----------------------------------------

Is that a hack? Because it looks fine to me. Are you thinking the spill code 
more generally should be reworked? That would be fine, but there is a strong 
case for eliminating use of MBB given known resource leak issues, so why not do 
that first, then iterate on additional improvements?

> Avoid using MappedByteBuffers for server side GROUP BY
> ------------------------------------------------------
>
>                 Key: PHOENIX-5123
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5123
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Priority: Major
>         Attachments: 5123-4.x-W.I.P.txt
>
>
> Like PHOENIX-5120 but for GROUP BY.
> Solution is a bit more tricky, since outline for sorting the access here is 
> truly random.
> [~apurtell] suggests to perhaps just use a RandomAccessFile for this.
> (I'm not sure that uses under the hood, though)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to