[
https://issues.apache.org/jira/browse/PHOENIX-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761526#comment-16761526
]
Hadoop QA commented on PHOENIX-5108:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12957724/PHOENIX-5108-4.x-HBase-1.3-v3.patch
against 4.x-HBase-1.3 branch at commit
77ea6eac02dc8a23ccea06713d64932b6affa415.
ATTACHMENT ID: 12957724
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
SchemaUtil.getEscapedTableName(Bytes.toString(ref.getFamily()),
Bytes.toString(ref.getQualifier()));
+ dColFullName += "\"" + dCol.getFamilyName().getString() + "\"" +
QueryConstants.NAME_SEPARATOR;
+ configuration.set(String.format("%s_%d", VALUE_NAME, i),
SchemaUtil.normalizeIdentifier(columns[i]));
+ testType(new ColumnInfo("\"a\".\"myColumn\"", Types.CHAR, 100),
"CHAR(100):\"a\".\"myColumn\"");
+ testType(new ColumnInfo("\"a\".\"myColumn\"", Types.VARCHAR, 100),
"VARCHAR(100):\"a\".\"myColumn\"");
+ testType(new ColumnInfo("\"a\".\"myColumn\"", Types.DECIMAL, 100, 10),
"DECIMAL(100,10):\"a\".\"myColumn\"");
+ testType(new ColumnInfo("\"a\".\"myColumn\"", Types.BINARY, 5),
"BINARY(5):\"a\".\"myColumn\"");
+ testType(new ColumnInfo("\"a\".\"myColumn\"",
PCharArray.INSTANCE.getSqlType(), 3), "CHAR(3) ARRAY:\"a\".\"myColumn\"");
+ testType(new ColumnInfo("\"a\".\"myColumn\"",
PDecimalArray.INSTANCE.getSqlType(), 10, 2), "DECIMAL(10,2)
ARRAY:\"a\".\"myColumn\"");
+ testType(new ColumnInfo("\"a\".\"myColumn\"",
PVarcharArray.INSTANCE.getSqlType(), 4), "VARCHAR(4) ARRAY:\"a\".\"myColumn\"");
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.mapreduce.util.IndexColumnNamesTest
org.apache.phoenix.index.IndexMaintainerTest
org.apache.phoenix.compile.QueryCompilerTest
org.apache.phoenix.util.PhoenixRuntimeTest
org.apache.phoenix.mapreduce.index.IndexScrutinyTableOutputTest
org.apache.phoenix.compile.QueryOptimizerTest
org.apache.phoenix.compile.TenantSpecificViewIndexCompileTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2311//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2311//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2311//console
This message is automatically generated.
> Normalize column names while generating SELECT statement in the spark
> connector
> -------------------------------------------------------------------------------
>
> Key: PHOENIX-5108
> URL: https://issues.apache.org/jira/browse/PHOENIX-5108
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Fix For: connectors-1.0.0
>
> Attachments: PHOENIX-5108-4.x-HBase-1.3-v3.patch,
> PHOENIX-5108-HBase-1.3.patch, PHOENIX-5108-v2-HBase-1.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
