[
https://issues.apache.org/jira/browse/PHOENIX-4940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763173#comment-16763173
]
Hadoop QA commented on PHOENIX-4940:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12957954/PHOENIX-4940.patch
against master branch at commit db1a07602732e0273d836ef940b03fa196ee7543.
ATTACHMENT ID: 12957954
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ list.add(new Object[] {
transactionProvider, mutable, localIndex, directApi, useSnapshot, false});
+ String createTableStr = "CREATE TABLE %s (TENANT_ID VARCHAR(15) NOT
NULL, ID INTEGER NOT NULL, NAME VARCHAR, "
+ ConnectionQueryServices queryServices =
connGlobal.unwrap(PhoenixConnection.class).getQueryServices();
+ selectSql = String.format("SELECT /*+ INDEX(%s) */ COUNT(*) FROM
%s", indexNameTenant, viewTenantName);
+ runIndexTool(directApi, useSnapshot, schemaName, dataTableName,
indexTableName, null,"-sp", "50", "-spa", "3");
+ runIndexTool(directApi, useSnapshot, schemaName, dataTableName,
indexTableName, null, 0, additionalArgs);
+ getArgValues(directApi, useSnapshot, schemaName,
dataTableName, indexTableName, tenantId);
+ return configureJobForAsyncIndex(schemaName, indexTable,
dataTable, useDirectApi, useSnapshot, tenantId);
+ private Job configureJobForPartialBuild(String schemaName, String
dataTable, String tenantId) throws Exception {
+ private Job configureJobForAsyncIndex(String schemaName, String
indexTable, String dataTable, boolean useDirectApi, boolean useSnapshot, String
tenantId)
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2314//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2314//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2314//console
This message is automatically generated.
> IndexTool should be able to rebuild tenant-owned indexes
> --------------------------------------------------------
>
> Key: PHOENIX-4940
> URL: https://issues.apache.org/jira/browse/PHOENIX-4940
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.0, 5.0.0
> Reporter: Geoffrey Jacoby
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-4940.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> IndexTool uses global connections to lookup the indexes which it's asked to
> rebuild, which means that it won't be able to see indexes owned by tenant
> views. We should add an optional tenantId parameter to it that will use a
> tenant connection (and potentially our MapReduce framework's tenant
> connection support) to allow for rebuilding those indexes as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
