[
https://issues.apache.org/jira/browse/PHOENIX-5128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763978#comment-16763978
]
Hadoop QA commented on PHOENIX-5128:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12958090/PHOENIX-5128.001.patch
against master branch at commit 08c4496addd6417f6d3c3965fd3114f791e9fd44.
ATTACHMENT ID: 12958090
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ static final Option SKIP_HEADER_OPT = new Option("k", "skip-header",
false, "Skip the first line of CSV files (the header)");
+ public RecordReader<LongWritable, Text> createRecordReader(InputSplit split,
TaskAttemptContext context) {
+ public void initialize(InputSplit genericSplit, TaskAttemptContext
context) throws IOException, InterruptedException {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2320//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2320//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2320//console
This message is automatically generated.
> Provide option to skip header with CsvBulkLoadTool
> --------------------------------------------------
>
> Key: PHOENIX-5128
> URL: https://issues.apache.org/jira/browse/PHOENIX-5128
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Attachments: PHOENIX-5128.001.patch
>
>
> We can pretty easily add a feature to skip the "header" row of a CSV file
> with a thin wrapper around the TextInputFormat/LineRecordReader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
