yanxinyi commented on a change in pull request #439: PHOENIX-2265 Disallow
creation of view over HBase table if PK not spe…
URL: https://github.com/apache/phoenix/pull/439#discussion_r256080970
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
##########
@@ -128,6 +128,24 @@ public MutationPlan compile(CreateTableStatement create)
throws SQLException {
viewTypeToBe = parentToBe.getViewType() == ViewType.MAPPED ?
ViewType.MAPPED : ViewType.UPDATABLE;
if (whereNode == null) {
viewStatementToBe = parentToBe.getViewStatement();
+
Review comment:
didn't look at the Phoenix supported gramma carefully, I moved code outside
wherenode check ifelse block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
