gjacoby126 commented on a change in pull request #434: PHOENIX-5018 Index 
mutations created by UPSERT SELECT will have wrong…
URL: https://github.com/apache/phoenix/pull/434#discussion_r256619727
 
 

 ##########
 File path: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableDDLPermissionsIT.java
 ##########
 @@ -211,23 +211,14 @@ public Void run() throws Exception {
 
             // we should be able to read the data from another index as well 
to which we have not given any access to
             // this user
-            verifyAllowed(createIndex(indexName2, phoenixTableName), 
unprivilegedUser);
 
 Review comment:
   @kadirozde - I'm curious what the purpose of these changes are. Have DDL 
permissions changed? If not, and your changes somehow break the existing test, 
is there a way to modify the test logic to keep the same test coverage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to