[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768860#comment-16768860
]
Hadoop QA commented on PHOENIX-3710:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12958789/PHOENIX-3710.002.patch
against master branch at commit 207263f7f0e45ebea02f2f12bec1f7293ad737c5.
ATTACHMENT ID: 12958789
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "CREATE %s INDEX %s ON %s (LPAD(UPPER(NAME,
'en_US'),8,'x')||'_xyz') ASYNC ",
+ "SELECT ID FROM %s WHERE LPAD(UPPER(NAME,
'en_US'),8,'x')||'_xyz' = 'xxUNAME2_xyz'",
+ + " SERVER FILTER BY (LPAD(UPPER(NAME, 'en_US'), 8,
'x') || '_xyz') = 'xxUNAME2_xyz'",
+ // Because the explain plan doesn't include double-quotes around
case-sensitive table names,
+ assertExplainPlan(localIndex, actualExplainPlan,
dataTableNameForExplain, indexTableNameForExplain, false);
+ assertExplainPlan(localIndex, actualExplainPlan, dataTableFullName,
indexTableFullName, true);
+ normalizeTableNames ?
SchemaUtil.normalizeIdentifier(dataTableFullName) : dataTableFullName);
+ normalizeTableNames ?
SchemaUtil.normalizeIdentifier(indexTableFullName) : indexTableFullName);
+ // We need to preserve the case-sensitivity quotes, else the ALTER
INDEX at the end of the
+ .setInput(job, PhoenixIndexDBWritable.class, snapshotName,
quotedDataTable, restoreDir, selectQuery);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2337//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2337//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2337//console
This message is automatically generated.
> Cannot use lowername data table name with indextool
> ---------------------------------------------------
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Matthew Shipton
> Assignee: Josh Elser
> Priority: Minor
> Attachments: PHOENIX-3710.002.patch, PHOENIX-3710.patch, test.sh,
> test.sql
>
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
