kadirozde commented on a change in pull request #441: PHOENIX-5089 Add tenantId
parameter to IndexScrunityTool
URL: https://github.com/apache/phoenix/pull/441#discussion_r258607406
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolIT.java
##########
@@ -551,11 +558,132 @@ public void testMaxOutputRows() throws Exception {
}
}
+ /**
+ * Tests that the config for max number of output rows is observed
+ */
+ @Test
+ public void testTenantId() throws Exception {
+ boolean doesTableExist = false;
+ try {
+ PhoenixRuntime.getTable(conn, MULTI_TENANT_DATA_TABLE_NAME);
+ doesTableExist = true;
+ } catch (TableNotFoundException e) {
+ doesTableExist = false;
+ }
+
+ // We already run this test, return.
+ if (doesTableExist) {
+ return;
+ }
Review comment:
This test does not use the test parameters and does not follow the overall
design within IndexScrutinyToolIT. I suggest either refactoring it to fit in
here or implementing it a separate test class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
