[
https://issues.apache.org/jira/browse/PHOENIX-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775792#comment-16775792
]
Hadoop QA commented on PHOENIX-5147:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12959866/PHOENIX-5147.4.x-HBase-1.3.003.patch
against 4.x-HBase-1.3 branch at commit
f9908c80ed8d986325867b44adf119f2d26ff783.
ATTACHMENT ID: 12959866
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ this.useMergeSortStrategy =
services.getProps().getBoolean(QueryServices.MERGE_SORT_STRATEGY_ENABLED,
QueryServicesOptions.DEFAULT_USE_MERGE_SORT_STRATEGY_ENABLE);
+ throw new IllegalArgumentException("Invalid strategy:
merge sort strategy is disabled.");
+ props.setProperty(QueryServices.MERGE_SORT_STRATEGY_ENABLED,
Boolean.toString(QueryServicesOptions.USE_MERGE_SORT_STRATEGY_DISABLE));
+ assertTrue(e.getMessage().contains("Invalid strategy: merge sort
strategy is disabled."));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2353//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2353//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2353//console
This message is automatically generated.
> Add an option to disable spooling ( SORT MERGE strategy in QueryCompiler )
> --------------------------------------------------------------------------
>
> Key: PHOENIX-5147
> URL: https://issues.apache.org/jira/browse/PHOENIX-5147
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0
> Reporter: Xu Cang
> Assignee: Xu Cang
> Priority: Major
> Attachments: PHOENIX-5147.4.x-HBase-1.3.001.patch,
> PHOENIX-5147.4.x-HBase-1.3.002.patch, PHOENIX-5147.4.x-HBase-1.3.003.patch
>
>
> We should add an option to allow database admin to disable using spooling
> from the server side.
> Especially before PHOENIX-5135 is fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
