[ 
https://issues.apache.org/jira/browse/PHOENIX-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778783#comment-16778783
 ] 

Geoffrey Jacoby commented on PHOENIX-2265:
------------------------------------------

[~yanxinyi] - Thanks for the patch. We try to keep tests that use miniclusters 
separate from ones that don't. (This is because tests without miniclusters tend 
to be fast and ones with them tend to be slower. Minicluster tests usually go 
in the it directories and usually have a suffix of IT (e.g ViewIT). 

If you're not able to verify this patch without a minicluster, it would be good 
to move the test to a file meant to have one. You'll also get a lot of wiring 
up for free.

Alternately, you could figure out a way to verify this that didn't use a 
minicluster, such as by using mocks, and keep the test where you have it. 

> Disallow creation of view over HBase table if PK not specified
> --------------------------------------------------------------
>
>                 Key: PHOENIX-2265
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2265
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Xinyi Yan
>            Priority: Major
>              Labels: newbie
>         Attachments: PHOENIX-2265-master.patch, PHOENIX-2265.patch, 
> PHOENIX-2265.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We currently allow a Phoenix view to be defined over an HBase table without 
> specifying a primary key.
> To repro, create an HBase table in the HBase shell:
> {code}
>  create 'hb1', 'f1'
> {code}
> Then create a view in Phoenix:
> {code}
> create view "hb1"("f1".a varchar);
> {code}
> This should yield an error, as we haven't specified a primary key.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to