[ 
https://issues.apache.org/jira/browse/PHOENIX-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784056#comment-16784056
 ] 

Hadoop QA commented on PHOENIX-5175:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12961081/PHOENIX-5175-master.patch
  against master branch at commit 29b6c9b1c9bf4ee4e31e31f1e618d1d8a3d351dc.
  ATTACHMENT ID: 12961081

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        
props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+            
props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+            
props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+            
props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+            
props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);
+        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, 
allowServerSideMutations);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2384//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2384//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2384//console

This message is automatically generated.

> Separate client settings for disabling server side mutations for upserts and 
> deletes
> ------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5175
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5175
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Minor
>         Attachments: PHOENIX-5175-master.patch
>
>
> PHOENIX-5026 added setting to disable server side mutations for upserts AND 
> deletes. This is an addition to that and provides separate knobs for upserts 
> and deletes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to