vincentpoon commented on a change in pull request #453: [PHOENIX-5172] Harden
the PQS canary synth test tool with retry mechanism and more logging
URL: https://github.com/apache/phoenix/pull/453#discussion_r263085695
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/tool/PhoenixCanaryTool.java
##########
@@ -464,11 +364,60 @@ public Void call() {
return 0;
}
+ private static Connection getConnectionWithRetry(String connectionURL,
Properties connProps){
+ Connection connection = null;
+ boolean isSuccess;
+ int currentAttempt = 1;
+ do {
+ try {
+ connection = DriverManager.getConnection(connectionURL,
connProps);
+ LOG.info("Successfully established connection within "
+ +currentAttempt+ "/" + MAX_ATTEMPTS + " attempts");
+ LOG.info("connectionURL :" +connectionURL);
+ LOG.info("connProps :" + connProps);
+ isSuccess = true;
+ } catch (Exception e) {
+ LOG.error("Failed to get connection." +
+ " Exhausted attempts : "+ currentAttempt+ "/" +
MAX_ATTEMPTS);
+ LOG.error("connectionURL :" + connectionURL);
+ LOG.error("connProps :" + connProps);
+ LOG.error("Something went wrong while getting Connection", e);
+ isSuccess = false;
+ sleepBeforeRetry(currentAttempt);
+ currentAttempt++;
+ }
+ } while (isSuccess != true && currentAttempt <= MAX_ATTEMPTS);
+ return connection;
+ }
+
+ private static void sleepBeforeRetry(int attempt) {
+ final int sleepTimesInSeconds= getSleepTime(attempt);
+ try {
+ LOG.info("Sleeping for " + sleepTimesInSeconds +" seconds");
+ TimeUnit.SECONDS.sleep(sleepTimesInSeconds);
+ } catch (InterruptedException e) {
+ LOG.error("Thread interrupted", e);
Review comment:
Looks like if we get an Interrupt, we're simply logging it and potentially
moving onto another retry. Instead we should propagate the exception so that
the current loop terminates. Someone is interrupting for a reason, and we
should respect that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
