twdsilva commented on a change in pull request #455: PHOENIX-4900 Modify
MAX_MUTATION_SIZE_EXCEEDED and MAX_MUTATION_SIZE_…
URL: https://github.com/apache/phoenix/pull/455#discussion_r263518523
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
##########
@@ -466,8 +466,11 @@ public SQLException newException(SQLExceptionInfo info) {
"because this client already has the maximum number" +
" of connections to the target cluster."),
- MAX_MUTATION_SIZE_EXCEEDED(729, "LIM01", "MutationState size is bigger
than maximum allowed number of rows"),
- MAX_MUTATION_SIZE_BYTES_EXCEEDED(730, "LIM02", "MutationState size is
bigger than maximum allowed number of bytes"),
+ MAX_MUTATION_SIZE_EXCEEDED(729, "LIM01", "MutationState size is bigger" +
+ " than maximum allowed number of rows, please turning autocommit
on and try it again."),
Review comment:
For upserts it would be slower to turn autocommit on since we would call
commit for every row.
I think it would be better if this message was .. try upserting rows in
smaller batches or using autocommit on for deletes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
