vincentpoon commented on a change in pull request #460: PHOENIX-5184: HBase and
Phoenix connection leaks in Indexing code path, OrphanViewTool and
PhoenixConfigurationUtil
URL: https://github.com/apache/phoenix/pull/460#discussion_r263981679
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -682,9 +694,15 @@ public int run(String[] args) throws Exception {
if (htable != null) {
htable.close();
}
- if(regionLocator != null) {
+ if (hConn != null) {
+ hConn.close();
Review comment:
Might want to take a look at Guava's Closer to see if that can help with
these cases. Register all the closeables, then call closer.close() once
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
