[
https://issues.apache.org/jira/browse/PHOENIX-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789506#comment-16789506
]
Hadoop QA commented on PHOENIX-5186:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12961969/PHOENIX-5186.4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
26d3734d3c2a05c56e92a0ea09a99fd90059f568.
ATTACHMENT ID: 12961969
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2412//console
This message is automatically generated.
> Remove redundant check for local in metadata client
> ---------------------------------------------------
>
> Key: PHOENIX-5186
> URL: https://issues.apache.org/jira/browse/PHOENIX-5186
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.1
> Reporter: Aman Poonia
> Assignee: Aman Poonia
> Priority: Minor
> Attachments: PHOENIX-5186.4.x-HBase-1.3.patch
>
>
> Remove redundant check for local index type in metadata client
> {code:java}
> if (index.getIndexType() != IndexType.LOCAL) {
> if (index.getIndexType() != IndexType.LOCAL) {
> if (table.getType() != PTableType.VIEW) {
> rowCount += updateStatisticsInternal(index.getPhysicalName(),
> index,
> updateStatisticsStmt.getProps(), true);
> } else {
> rowCount += updateStatisticsInternal(table.getPhysicalName(),
> index,
> updateStatisticsStmt.getProps(), true);
> }
> }
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
