karanmehta93 commented on a change in pull request #453: [PHOENIX-5172] Harden
the PQS canary synth test tool with retry mechanism and more logging
URL: https://github.com/apache/phoenix/pull/453#discussion_r264901227
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/tool/PhoenixCanaryTool.java
##########
@@ -464,11 +363,56 @@ public Void call() {
return 0;
}
+ private Connection getConnectionWithRetry(String connectionURL) {
+ Connection connection=null;
+ try{
+ connection = getConnectionWithRetry(connectionURL, true);
+ } catch (Exception e) {
+ LOG.error("Failed to get connection with namespace enabled", e);
+ try {
+ connection = getConnectionWithRetry(connectionURL, false);
+ } catch (Exception ex) {
+ LOG.error("Failed to get connection without namespace
enabled", ex);
+ }
+ }
+ return connection;
Review comment:
Add consolidated error line here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
