comnetwork commented on a change in pull request #444: PHOENIX-5148
URL: https://github.com/apache/phoenix/pull/444#discussion_r265401760
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/GroupByCompiler.java
##########
@@ -63,9 +63,10 @@
private final boolean isOrderPreserving;
Review comment:
Yes , I think the member variable `isOrderPreserving` is required because it
saved the result of `OrderPreservingTracker.isOrderPreserving()`.
`GroupBy.isOrderPreserving()` is used by many classes under `compile` and
`execute` packages.
FYI, the `GroupBy` class is a immutable class , and every time we compile
the `group by clause` (we compile it twice in
`QueryCompiler.compileSingleFlatQuery`) , a new GroupBy instance is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
