kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent
Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r266720274
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java
##########
@@ -162,7 +162,7 @@ public void testBytesRowsForSelectWithLimitIgnored()
throws Exception {
List<Object> binds = Lists.newArrayList();
try (Connection conn = DriverManager.getConnection(getUrl())) {
Estimate info = getByteRowEstimates(conn, sql, binds);
- assertEquals((Long) 691L, info.estimatedBytes);
+ assertEquals((Long) 979L, info.estimatedBytes);
Review comment:
The entire test suite uses hard coded values. This test suite needs to be
restructured so that these values are set using a formula. At this moment, this
test suite is useless to me since the expected value is set to the actual value
manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
