BinShi-SecularBird commented on a change in pull request #471: PHOENIX-5176
KeyRange.compareUpperRange(KeyRang 1, KeyRang 2) returns wrong result when two
key ranges have the same upper bound values but one is inclusive and another is
exclusive
URL: https://github.com/apache/phoenix/pull/471#discussion_r266995363
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/KeyRange.java
##########
@@ -519,7 +520,8 @@ public KeyRange union(KeyRange other) {
return Lists.transform(keys, POINT);
}
- private static int compareUpperRange(KeyRange rowKeyRange1,KeyRange
rowKeyRange2) {
+ @VisibleForTesting
Review comment:
I'll remove @VisibleForTesting. This needs to be public, because it is used
by changes that I'm working on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
