gokceni commented on a change in pull request #469: PHOENIX-5156 Consistent
Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r269294461
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java
##########
@@ -74,18 +75,18 @@
private final boolean addArrayCell;
@SuppressWarnings("unchecked")
- public HashJoinRegionScanner(RegionScanner scanner, TupleProjector
projector,
+ public HashJoinRegionScanner(RegionScanner scanner, Scan scan,
TupleProjector projector,
HashJoinInfo joinInfo, ImmutableBytesPtr
tenantId,
RegionCoprocessorEnvironment env, boolean
useQualifierAsIndex,
boolean useNewValueColumnQualifier)
throws IOException {
- this(env, scanner, null, null, projector, joinInfo,
+ this(env, scanner, scan,null, null, projector, joinInfo,
tenantId, useQualifierAsIndex, useNewValueColumnQualifier);
}
@SuppressWarnings("unchecked")
- public HashJoinRegionScanner(RegionCoprocessorEnvironment env,
RegionScanner scanner,
+ public HashJoinRegionScanner(RegionCoprocessorEnvironment env,
RegionScanner scanner, Scan scan,
final Set<KeyValueColumnExpression>
arrayKVRefs,
Review comment:
Is Scan parameter used anywhere? I could not find where you are using this
one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
