[
https://issues.apache.org/jira/browse/PHOENIX-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802243#comment-16802243
]
Hadoop QA commented on PHOENIX-5138:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12963780/PHOENIX-5138-v2.patch
against master branch at commit 679dd55d504123b584eed88baecf98f197438bf9.
ATTACHMENT ID: 12963780
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private Connection getConnection(boolean tenantSpecific, String
tenantId, boolean isNamespaceMappingEnabled)
+ private void testMergeViewIndexSequencesHelper(boolean
isNamespaceMappingEnabled) throws Exception {
+ PhoenixConnection conn = getConnection(false, null,
isNamespaceMappingEnabled).unwrap(PhoenixConnection.class);
+ PName viewIndexTable =
PNameFactory.newName(MetaDataUtil.getViewIndexPhysicalName(tableName));
+ createViewIndexSequenceWithOldName(cqs, tenantOne, viewIndexTable,
isNamespaceMappingEnabled);
+ createViewIndexSequenceWithOldName(cqs, tenantTwo, viewIndexTable,
isNamespaceMappingEnabled);
+ createViewIndexSequenceWithOldName(cqs, null, viewIndexTable,
isNamespaceMappingEnabled);
+ cqs.incrementSequences(allocations,
EnvironmentEdgeManager.currentTimeMillis(), incrementedValues,
+ SequenceKey sequenceUpgrade =
MetaDataUtil.getViewIndexSequenceKey(null, viewIndexTable, 0,
isNamespaceMappingEnabled);
+ cqs.incrementSequences(afterUpgradeAllocations,
EnvironmentEdgeManager.currentTimeMillis(), afterUpgradeValues,
afterUpgradeExceptions);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2459//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2459//console
This message is automatically generated.
> ViewIndexId sequences created after PHOENIX-5132 shouldn't collide with ones
> created before it
> ----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5138
> URL: https://issues.apache.org/jira/browse/PHOENIX-5138
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 5.1
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Blocker
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5138-v2.patch, PHOENIX-5138.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> PHOENIX-5132 changed the ViewIndexId generation logic to use one sequence per
> physical view index table, whereas before it had been tenant + physical
> table. This removed the possibility of a tenant view index and a global view
> index having colliding ViewIndexIds.
> However, existing Phoenix environments may have already created tenant-owned
> view index ids using the old sequence, and under PHOENIX-5132 if they create
> another, its ViewIndexId will got back to MIN_VALUE, which could cause a
> collision with an existing view index id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
