karanmehta93 commented on a change in pull request #463: Phoenix stats Initial
Commit
URL: https://github.com/apache/phoenix/pull/463#discussion_r272302485
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
##########
@@ -550,15 +550,48 @@ public BaseResultIterators(QueryPlan plan, Integer
perScanLimit, Integer offset,
}
return ranges;
}
-
+
+ private List<KeyRange> getRegionRowKeyRanges() throws SQLException {
Review comment:
I might be missing some context here but I see this piece of code in this
file which can re-used and handles the required corner cases.
```
static final Function<HRegionLocation, KeyRange> TO_KEY_RANGE = new
Function<HRegionLocation, KeyRange>() {
@Override
public KeyRange apply(HRegionLocation region) {
return
KeyRange.getKeyRange(region.getRegionInfo().getStartKey(),
region.getRegionInfo().getEndKey());
}
};
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
