[ 
https://issues.apache.org/jira/browse/PHOENIX-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810479#comment-16810479
 ] 

Hadoop QA commented on PHOENIX-5090:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12964512/5090-v2.txt
  against master branch at commit 43600fbf39cda4336be9736fd8c653044e3d85ee.
  ATTACHMENT ID: 12964512

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        final boolean autoFlush = connection.getAutoCommit() || 
tableRef.getTable().isTransactional();
+        final boolean autoFlush = connection.getAutoCommit() || 
plan.getTableRef().getTable().isTransactional();
+        final boolean autoFlush = connection.getAutoCommit() || 
tableRef.getTable().isTransactional();

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2485//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2485//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2485//console

This message is automatically generated.

> Discuss: Allow transactional writes without buffering the entire transaction 
> on the client.
> -------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5090
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5090
>             Project: Phoenix
>          Issue Type: Wish
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Major
>         Attachments: 5090-looksee.txt, 5090-v1.txt, 5090-v2.txt
>
>
> Currently it is not possible execute transactions in Phoenix that are too 
> large to be buffered entirely on the client.
> Both Tephra and Omid support writing uncommitted data to HBase immediately 
> and at full speed. The client still needs to keep tracks of the rows changes 
> for:
> # Conflict detection
> # (for Omid) writing the shadow cells
> I'd like to do some brainstorming here.
> * It should *always* be enough to only hold on to the changed rows (and 
> columns?) only for _conflict resolution_ and free the rest from the client as 
> soon as the uncommitted data is written to HBase.
> * For the shadows cells we need only keep the rows changed, right?
> * There are situations where we can avoid the client site buffering entirely 
> (perhaps only for Tephra) when we declare a table or upsert not to 
> participate in conflict resolution.
> [~tdsilva], [~ohads], [~yonigo], [~jamestaylor], [~vincentpoon], more, better 
> ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to