[
https://issues.apache.org/jira/browse/PHOENIX-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810667#comment-16810667
]
Hadoop QA commented on PHOENIX-5228:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12964954/PHOENIX-5228-4.x-HBase-1.2.patch
against 4.x-HBase-1.2 branch at commit
43600fbf39cda4336be9736fd8c653044e3d85ee.
ATTACHMENT ID: 12964954
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 41 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ logger.info("Using custom Phoenix Index RPC Handling with index
rpc priority " + indexPriority + " and metadata rpc priority " +
metadataPriority);
+ logger.error(addCustomAnnotations("Error trying to
remove hash cache for " + entry, connection),
+ logger.warn(addCustomAnnotations("Unable to remove hash cache
for " + remainingOnServers, connection),
+ logger.warn("Decrement of -" +
PENDING_DISABLE_INACTIVE_STATE_COUNT +" for index :" +
index.getName().getString() + "of table: " + dataPTable.getName().getString(),
e);
+ logger.debug("Could not find " + dataTableFullName + "
in " + onlyTheseTables);
+ logger.debug(dataTableFullName + " does not contain "
+ indexPTable.getName().getString());
+ logger.debug("Index rebuild has been skipped because
not all regions of index table="
+ logger.warn("Unexpected index state of " +
indexTableFullName + "=" + indexState + ". Skipping partial rebuild attempt.");
+ logger.debug("Still must wait " +
(indexStateCell.getTimestamp() + forwardOverlapDurationMs - currentTime) + "
before starting rebuild for " + indexTableFullName);
+ logger.debug("We have found " +
indexPTable.getIndexState() + " Index:" + indexPTable.getName()
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2488//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2488//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2488//console
This message is automatically generated.
> use slf4j for logging in phoenix project
> ----------------------------------------
>
> Key: PHOENIX-5228
> URL: https://issues.apache.org/jira/browse/PHOENIX-5228
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.1, 5.1.0
> Reporter: Mihir Monani
> Assignee: Xinyi Yan
> Priority: Trivial
> Labels: SFDC
> Attachments: PHOENIX-5228-4.x-HBase-1.2.patch,
> PHOENIX-5228-4.x-HBase-1.3.patch, PHOENIX-5228-4.x-HBase-1.4.patch,
> PHOENIX-5228.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would be good to use slf4j for logging in phoenix project. Here is list of
> files where doesn't use slf4j.
> phoenix-core :-
> {noformat}
> WALRecoveryRegionPostOpenIT.java
> WALReplayWithIndexWritesAndCompressedWALIT.java
> BasePermissionsIT.java
> ChangePermissionsIT.java
> IndexRebuildIncrementDisableCountIT.java
> InvalidIndexStateClientSideIT.java
> MutableIndexReplicationIT.java
> FailForUnsupportedHBaseVersionsIT.java
> SecureUserConnectionsIT.java
> PhoenixMetricsIT.java
> BaseTracingTestIT.java
> PhoenixTracingEndToEndIT.java
> PhoenixRpcSchedulerFactory.java
> IndexHalfStoreFileReaderGenerator.java
> BinaryCompatibleBaseDecoder.java
> ServerCacheClient.java
> CallRunner.java
> MetaDataRegionObserver.java
> PhoenixAccessController.java
> ScanRegionObserver.java
> TaskRegionObserver.java
> DropChildViewsTask.java
> IndexRebuildTask.java
> BaseQueryPlan.java
> HashJoinPlan.java
> CollationKeyFunction.java
> Indexer.java
> LockManager.java
> BaseIndexBuilder.java
> IndexBuildManager.java
> NonTxIndexBuilder.java
> IndexMemStore.java
> BaseTaskRunner.java
> QuickFailingTaskRunner.java
> TaskBatch.java
> ThreadPoolBuilder.java
> ThreadPoolManager.java
> IndexManagementUtil.java
> IndexWriter.java
> IndexWriterUtils.java
> KillServerOnFailurePolicy.java
> ParallelWriterIndexCommitter.java
> RecoveryIndexWriter.java
> TrackingParallelWriterIndexCommitter.java
> PhoenixIndexFailurePolicy.java
> PhoenixTransactionalIndexer.java
> SnapshotScanner.java
> PhoenixEmbeddedDriver.java
> PhoenixResultSet.java
> QueryLogger.java
> QueryLoggerDisruptor.java
> TableLogWriter.java
> PhoenixInputFormat.java
> PhoenixOutputFormat.java
> PhoenixRecordReader.java
> PhoenixRecordWriter.java
> PhoenixServerBuildIndexInputFormat.java
> PhoenixMRJobSubmitter.java
> PhoenixConfigurationUtil.java
> Metrics.java
> DefaultStatisticsCollector.java
> StatisticsScanner.java
> PhoenixMetricsSink.java
> TraceReader.java
> TraceSpanReceiver.java
> TraceWriter.java
> Tracing.java
> EquiDepthStreamHistogram.java
> PhoenixMRJobUtil.java
> QueryUtil.java
> ServerUtil.java
> ZKBasedMasterElectionUtil.java
> IndexTestingUtils.java
> StubAbortable.java
> TestIndexWriter.java
> TestParalleIndexWriter.java
> TestParalleWriterIndexCommitter.java
> TestWALRecoveryCaching.java
> LoggingSink.java
> ParameterizedPhoenixCanaryToolIT.java
> CoprocessorHConnectionTableFactoryTest.java
> TestUtil.java{noformat}
> phoenix-tracing-webapp :-
> {noformat}
> org/apache/phoenix/tracingwebapp/http/Main.java
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
