swaroopak commented on a change in pull request #476: PHOENIX-5228 use slf4j
for logging in phoenix project
URL: https://github.com/apache/phoenix/pull/476#discussion_r272707470
##########
File path:
phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALRecoveryRegionPostOpenIT.java
##########
@@ -75,14 +73,16 @@
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import com.google.common.collect.Maps;
import com.google.common.collect.Multimap;
@Category(NeedsOwnMiniClusterTest.class)
public class WALRecoveryRegionPostOpenIT extends BaseTest {
- private static final Log LOG =
LogFactory.getLog(WALRecoveryRegionPostOpenIT.class);
+ private static final Logger logger =
LoggerFactory.getLogger(WALRecoveryRegionPostOpenIT.class);
Review comment:
I understand that using logger is tempting. But, if we do not change the
variable name here, it will reduce the change in the files.
Also, variables with such access modifiers are capitalized, for the
consistency, do you want to follow the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
