swaroopak commented on a change in pull request #449: PHOENIX-5167: fix some
LGTM alerts
URL: https://github.com/apache/phoenix/pull/449#discussion_r272752459
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Column.java
##########
@@ -62,8 +62,14 @@ public Column(Column column) {
*/
@Override
public boolean equals(Object column) {
- Column col = (Column)column;
- return (getType() == col.getType());
+ if (column == null) {
Review comment:
This is really good. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
