swaroopak commented on a change in pull request #477: PHOENIX-5230 Fix ChangePermissionsIT and TableDDLPermissionIT on master URL: https://github.com/apache/phoenix/pull/477#discussion_r272753940
########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ########## @@ -16,62 +16,66 @@ */ package org.apache.phoenix.end2end; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; - -import java.io.IOException; -import java.lang.reflect.UndeclaredThrowableException; -import java.security.PrivilegedExceptionAction; -import java.sql.Connection; -import java.sql.DriverManager; -import java.sql.PreparedStatement; -import java.sql.ResultSet; -import java.sql.SQLException; -import java.sql.Statement; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.HashSet; -import java.util.List; -import java.util.Properties; -import java.util.Set; - +import com.google.common.base.Joiner; +import com.google.common.base.Throwables; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; Review comment: Given the recent jira for logging, let's use org.slf4j.Logger and org.slf4j.LoggerFactory. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
