[
https://issues.apache.org/jira/browse/PHOENIX-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814739#comment-16814739
]
Josh Elser commented on PHOENIX-5213:
-------------------------------------
{quote}FWIW we don't actually have a slf4j-log4j12 dependency defined anywhere
in our poms.
{quote}
This should be something we add ourselves, since the expectation of Phoenix is
that we're using Log4j as the logging implementation. Probably in
phoenix-client makes the most sense (since we expect it to be there in the
pheonix-client artifact). Nit picky and not something you need to fix here.
{quote}Btw, on #3, I still don't think there's a way to change the naming
convention in the repo. Again, you can change the jar name when it's created in
/target , which can then be bundled in the assembly tarball, but when
installing to the repo, it is always renamed to artifact-version.jar . So we
still have that inconsistency.
{quote}
I'm surprised looking at the output of the build given your previous comment:
{noformat}
$ ll phoenix-client/target
total 563656
drwxr-xr-x 3 jelser staff 96B Apr 10 13:52 classes
drwxr-xr-x 3 jelser staff 96B Apr 10 13:52 maven-archiver
drwxr-xr-x 3 jelser staff 96B Apr 10 13:52 maven-shared-archive-resources
-rw-r--r-- 1 jelser staff 13K Apr 10 13:52
original-phoenix-4.15.0-HBase-1.4-SNAPSHOT-client.jar
-rw-r--r-- 1 jelser staff 103M Apr 10 13:54
phoenix-4.15.0-HBase-1.4-SNAPSHOT-client-embedded.jar
-rw-r--r-- 1 jelser staff 103M Apr 10 13:53
phoenix-4.15.0-HBase-1.4-SNAPSHOT-client.jar
-rw-r--r-- 1 jelser staff 51M Apr 10 13:54
phoenix-client-4.15.0-HBase-1.4-SNAPSHOT-embedded-sources.jar
{noformat}
I thought you were saying that Maven wasn't doing what you needed when the
renaming was happening. Did you decide to just leave the naming as it was
before? Everything good in how you wanted to use/reference this artifact
downstream from Phoenix?
> Phoenix-client improvements: add more relocations, exclude log binding, add
> source jar
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-5213
> URL: https://issues.apache.org/jira/browse/PHOENIX-5213
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-5213.4.x-HBase-1.4.v1.patch,
> PHOENIX-5213.4.x-HBase-1.4.v2.patch
>
>
> To make the existing phoenix-client, I'm proposing the following changes:
> 1) Add additional relocations of some packages
> Add a new "embedded" classifier to phoenix-client that does the following:
> 2) Exclude the slf4j-log4j12 binding. Apparently this isn't pulled in
> directly from phoenix-core itself, but transitively from other projects.
> It's generally considered best practice to not impose a log binding on
> downstream projects. The slf4j-log4j12 jar will still be in the phoenix
> tarball's /lib folder.
> 3) Create a source jar for phoenix-client embedded.
> 4) Create a dependency-reduced pom, so that the client can be used directly
> in downstream projects without having to exclude transitive artifacts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
