BinShi-SecularBird commented on a change in pull request #479: PHOENIX-5231
Configurable Stats Cache
URL: https://github.com/apache/phoenix/pull/479#discussion_r274092966
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
##########
@@ -109,7 +110,7 @@
*/
public class ConnectionlessQueryServicesImpl extends DelegateQueryServices
implements ConnectionQueryServices {
private static ServerName SERVER_NAME =
ServerName.parseServerName(HConstants.LOCALHOST +
Addressing.HOSTNAME_PORT_SEPARATOR + HConstants.DEFAULT_ZOOKEPER_CLIENT_PORT);
-
+ private static final QueryServicesHelper queryServicesHelper = new
QueryServicesHelper();
Review comment:
Is it possible to push "QueryServicesHelper queryServicesHelper = new
QueryServicesHelper();" to ConnectionQueryServices? Do
ConnectionQueryServicesImpl and ConnectionlessQueryServicesImpl need different
implementation of GuidePostsCache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
