karanmehta93 commented on a change in pull request #482: PHOENIX-4925 Use
Segment tree to organize Guide Post Info
URL: https://github.com/apache/phoenix/pull/482#discussion_r275082495
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/DefaultStatisticsCollector.java
##########
@@ -276,11 +273,14 @@ private void writeStatistics(final Region region,
boolean delete, List<Mutation>
continue;
}
if (!guidePostsInfoWriterMap.containsKey(cfKey)) {
- Pair<Long, GuidePostsInfoBuilder> emptyGps = new
Pair<Long, GuidePostsInfoBuilder>(0l, new GuidePostsInfoBuilder());
+ Pair<Pair<Long, Long>, GuidePostChunkBuilder> emptyGps =
+ new Pair<Pair<Long, Long>,
GuidePostChunkBuilder>(new Pair(0l, 0l), new GuidePostChunkBuilder());
guidePostsInfoWriterMap.put(cfKey, emptyGps);
}
}
}
+
+ Set<ImmutableBytesPtr> fams = guidePostsInfoWriterMap.keySet();
Review comment:
This line has been moved from no 259 to 283, which means that
`guidePostsInfoWriterMap` will potentially now have 1 new entry as compared to
previous behavior. What is this needed for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
