karanmehta93 commented on a change in pull request #458: PHOENIX-5181 support Math sin/cos/tan functions URL: https://github.com/apache/phoenix/pull/458#discussion_r275082886
########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/MathTrigFunctionEnd2EndIT.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.apache.phoenix.util.TestUtil.closeStmtAndConn; +import static org.junit.Assert.assertTrue; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.ResultSet; + +import org.apache.phoenix.expression.function.CosFunction; +import org.apache.phoenix.expression.function.SinFunction; +import org.apache.phoenix.expression.function.TanFunction; +import org.junit.Before; +import org.junit.Test; + +/** + * End to end tests for + * {@link org.apache.phoenix.expression.function.CosFunction} + * {@link org.apache.phoenix.expression.function.SinFunction} + * {@link org.apache.phoenix.expression.function.TanFunction} + */ + +public class MathTrigFunctionEnd2EndIT extends ParallelStatsDisabledIT { + + private static final String KEY = "key"; + private String tableName; + + @Before + public void initTable() throws Exception { + Connection conn = null; + PreparedStatement stmt = null; + tableName = generateUniqueName(); + + try { + conn = DriverManager.getConnection(getUrl()); + String ddl; + ddl = + "CREATE TABLE " + tableName + " (k VARCHAR NOT NULL PRIMARY KEY, doub DOUBLE)"; + conn.createStatement().execute(ddl); + conn.commit(); Review comment: Commit is not needed after ddl statements. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
