dbwong commented on a change in pull request #482: PHOENIX-4925 Use Segment
tree to organize Guide Post Info
URL: https://github.com/apache/phoenix/pull/482#discussion_r275049348
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java
##########
@@ -185,20 +185,23 @@
public static final String USE_REVERSE_SCAN_ATTRIB =
"phoenix.query.useReverseScan";
- // Config parameters for stats collection
+ // Config parameters for stats related
+ public static final String USE_STATS_FOR_PARALLELIZATION =
"phoenix.use.stats.parallelization";
+ public static final String STATS_COLLECTION_ENABLED =
"phoenix.stats.collection.enabled";
public static final String STATS_UPDATE_FREQ_MS_ATTRIB =
"phoenix.stats.updateFrequency";
public static final String MIN_STATS_UPDATE_FREQ_MS_ATTRIB =
"phoenix.stats.minUpdateFrequency";
public static final String STATS_GUIDEPOST_WIDTH_BYTES_ATTRIB =
"phoenix.stats.guidepost.width";
public static final String STATS_GUIDEPOST_PER_REGION_ATTRIB =
"phoenix.stats.guidepost.per.region";
public static final String STATS_USE_CURRENT_TIME_ATTRIB =
"phoenix.stats.useCurrentTime";
-
public static final String RUN_UPDATE_STATS_ASYNC =
"phoenix.update.stats.command.async";
public static final String STATS_SERVER_POOL_SIZE =
"phoenix.stats.pool.size";
public static final String COMMIT_STATS_ASYNC =
"phoenix.stats.commit.async";
// Maximum size in bytes taken up by cached table stats in the client
public static final String STATS_MAX_CACHE_SIZE =
"phoenix.stats.cache.maxSize";
// The size of the thread pool used for refreshing cached table stats in
stats client cache
public static final String STATS_CACHE_THREAD_POOL_SIZE =
"phoenix.stats.cache.threadPoolSize";
+ // The targeted size of the guide post chunk measured in the number of
guide posts.
+ public static final String STATS_TARGETED_CHUNK_SIZE =
"phoenix.stats.targeted.chunk.size";
Review comment:
I don’t think this should be on the query level and Should be on the table
level sicne we won't be collecting stats for the table multiple times ideally.
With you guidepost chunk shouldn't this match the collected size? Is this for
a 1 size chunk for backward compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
