dbwong commented on a change in pull request #479: PHOENIX-5231 Configurable
Stats Cache
URL: https://github.com/apache/phoenix/pull/479#discussion_r275567026
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -420,8 +421,11 @@ public ConnectionQueryServicesImpl(QueryServices
services, ConnectionInfo connec
list.add(queue);
}
connectionQueues = ImmutableList.copyOf(list);
+
// A little bit of a smell to leak `this` here, but should not be a
problem
- this.tableStatsCache = new GuidePostsCache(this, config);
+ this.tableStatsCache =
queryServicesHelper.getGuidePostsCache(props.get(GUIDE_POSTS_CACHE_FACTORY_CLASS,
+ QueryServicesOptions.DEFAULT_GUIDE_POSTS_CACHE_FACTORY_CLASS),
this, config);
Review comment:
As discussed offline I made
https://issues.apache.org/jira/browse/PHOENIX-5244 to track this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
