[
https://issues.apache.org/jira/browse/PHOENIX-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818501#comment-16818501
]
Hadoop QA commented on PHOENIX-5203:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12966016/PHOENIX-5203.master.v4.patch
against master branch at commit 2e12af8e0d8c58a7ad4178b0476057d02fb1a7a3.
ATTACHMENT ID: 12966016
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev patch that doesn't require tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2509//console
This message is automatically generated.
> Update contributing guidelines on Phoenix website
> -------------------------------------------------
>
> Key: PHOENIX-5203
> URL: https://issues.apache.org/jira/browse/PHOENIX-5203
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Swaroopa Kadam
> Priority: Trivial
> Attachments: PHOENIX-5203.master.v1.patch,
> PHOENIX-5203.master.v2.patch, PHOENIX-5203.master.v3.patch,
> PHOENIX-5203.master.v4.patch
>
>
> Add details about patch file naming convention, assumption that patch files
> only work if it contains single commit in them (for Hadoop QA) and asking
> users to raise PR's as well along with patch files since it makes it easier
> for others to review. This will help improve onboarding.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
