JohnNPhillips commented on a change in pull request #484: PHOENIX-5239: Send
persistent subquery caches to all regionservers
URL: https://github.com/apache/phoenix/pull/484#discussion_r275987056
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java
##########
@@ -310,7 +311,7 @@ public TaskExecutionMetricsHolder getTaskExecutionMetric()
{
}
}));
} else {
- if (LOG.isDebugEnabled())
{LOG.debug(addCustomAnnotations("NOT adding cache entry to be sent for " +
entry + " since one already exists for that entry", connection));}
Review comment:
This generates a log line for every single region (not just unique
regionservers) that aren't sent a cache. For large tables, this makes `debug`
level logs _very_ noisy, even for testing. However, if phoenix tries to avoid
making backwards incompatible changes to debug level logs, I can remove this
from the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
