dbwong commented on a change in pull request #485: Add common utility function
ScanUtil.splityKeyRangesByBoundaries()
URL: https://github.com/apache/phoenix/pull/485#discussion_r276039507
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##########
@@ -953,4 +953,80 @@ public static int getClientVersion(Scan scan) {
public static void setClientVersion(Scan scan, int version) {
scan.setAttribute(BaseScannerRegionObserver.CLIENT_VERSION,
Bytes.toBytes(version));
}
+
+ /**
+ * Split the key ranges into multiple groups along the given boundaries
+ *
+ * @param boundaries
+ * The boundaries is a byte[] list like "b0, b1, ..., bn" which forms
+ * space (UNBOUND, b0), [b0, b1), ..., [bn, UNBOUND)
+ * @param keyRanges
+ * The key ranges to split along the given boundaries. Coalesced.
+ * @return
+ * key ranges in two dimensions.
+ */
+ public static List<List<KeyRange>> splitKeyRangesByBoundaries(List<byte[]>
boundaries, List<KeyRange> keyRanges) {
+ if (boundaries == null || keyRanges == null || keyRanges.size() == 0) {
+ return null;
+ }
+
+ ScanUtil.BytesComparator comparator = ScanUtil.getComparator(true,
SortOrder.ASC);
Review comment:
This doesn't seem to be configurable consider if static final field makes
more sense. Either is okay but as this will be allocated every query maybe
keeping it around makes more sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
