BinShi-SecularBird commented on a change in pull request #485: Add common
utility function ScanUtil.splityKeyRangesByBoundaries()
URL: https://github.com/apache/phoenix/pull/485#discussion_r276277403
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/KeyRange.java
##########
@@ -519,16 +519,21 @@ public KeyRange union(KeyRange other) {
return Lists.transform(keys, POINT);
}
- public static int compareUpperRange(KeyRange rowKeyRange1,KeyRange
rowKeyRange2) {
- int result = Boolean.compare(rowKeyRange1.upperUnbound(),
rowKeyRange2.upperUnbound());
+ public int compareUpperRange(byte[] b, int o, int l, boolean isInclusive) {
Review comment:
I'll add comment. BTW, that's the existing function. I just added helper
function around the existing function,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
