ChinmaySKulkarni commented on a change in pull request #486: PHOENIX-5173: LIKE
and ILIKE statements return empty result list for …
URL: https://github.com/apache/phoenix/pull/486#discussion_r276897958
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
##########
@@ -507,9 +507,6 @@ public Expression visitLeave(LikeParseNode node,
List<Expression> children) thro
}
if (index == -1) {
String rhsLiteral = LikeExpression.unescapeLike(pattern);
- if (lhsMaxLength != null && lhsMaxLength !=
rhsLiteral.length()) {
Review comment:
Looks good, but just confirm that this does cause any regressions to
existing like conditions that have wildcards?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
