[
https://issues.apache.org/jira/browse/PHOENIX-5251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823588#comment-16823588
]
Hadoop QA commented on PHOENIX-5251:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12966660/PHOENIX-5251.4.x-HBase-1.3.v1.patch
against 4.x-HBase-1.3 branch at commit
4ef749dd92d4af7529a07d343cb0186302979a14.
ATTACHMENT ID: 12966660
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 6 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ AtomicReference<ArrayList<BaseMasterAndRegionObserver>>
accessControllers = new AtomicReference<>();
+ List<BaseMasterAndRegionObserver> coprocessors =
cpHost.findCoprocessors(BaseMasterAndRegionObserver.class);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2525//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2525//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2525//console
This message is automatically generated.
> Avoid taking explicit lock by using AtomicReference in
> PhoenixAccessController class
> ------------------------------------------------------------------------------------
>
> Key: PHOENIX-5251
> URL: https://issues.apache.org/jira/browse/PHOENIX-5251
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Minor
> Attachments: PHOENIX-5251.4.x-HBase-1.3.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> By [~elserj] on PHOENIX-5070
> If we want to avoid taking an explicit lock, what about using AtomicReference
> instead? Can we spin out another Jira issue to fix that?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
