kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent
Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r278705835
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
##########
@@ -849,4 +855,35 @@ public static long
getIndexPendingDisableCount(PhoenixConnection conn, String fa
throw new IOException(e);
}
}
+
+ public static void setScanAttributes(Scan scan, PTable table,
PhoenixConnection phoenixConnection) throws SQLException {
+ if (table.isTransactional() || table.isImmutableRows() ||
table.getType() != PTableType.INDEX) {
Review comment:
So you suggest adding tens of lines of code for removing couple lines of
code. That does not sound good. I really do not understand why the if statement
for checking the input arguments is an issue here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
