ChinmaySKulkarni commented on a change in pull request #4: PHOENIX-5238 Provide
an option to pass hints with PhoenixRDD and Data…
URL: https://github.com/apache/phoenix-connectors/pull/4#discussion_r279940056
##########
File path:
phoenix-spark/src/test/java/org/apache/phoenix/spark/datasource/v2/PhoenixDataSourceTest.java
##########
@@ -64,6 +67,8 @@ public void testPhoenixConfigsExtractedProperly() {
assertEquals(V1, p.getProperty(P1));
assertEquals(V2, p.getProperty(P2));
assertEquals(V3, p.getProperty(P3));
+ assertEquals(V3, p.getProperty(P3));
+ assertEquals(true, Boolean.valueOf(p.getProperty(NO_CACHE)));
Review comment:
This test isn't testing your change at all..Here you are using the
extraOptions to set the property and just checking that the property is set.
Ideally, we want to use extraOptions to set HBase/Phoenix properties if they
are valid configs we set in say hbase-site.xml. In this case, `NO_CACHE` is not
such a config so we are using a different way to set this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
