gokceni commented on a change in pull request #469: PHOENIX-5156 Consistent
Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r280632322
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
##########
@@ -579,16 +798,79 @@ public void
postBatchMutateIndispensably(ObserverContext<RegionCoprocessorEnviro
private void doPost(ObserverContext<RegionCoprocessorEnvironment> c,
BatchMutateContext context) throws IOException {
try {
- doPostWithExceptions(c,context);
- return;
+ doPostWithExceptions(c,context);
+ return;
} catch (Throwable e) {
- rethrowIndexingException(e);
+ rethrowIndexingException(e);
}
throw new RuntimeException(
- "Somehow didn't complete the index update, but didn't return
succesfully either!");
- }
+ "Somehow didn't complete the index update, but didn't return
succesfully either!");
+ }
private void
doPostWithExceptions(ObserverContext<RegionCoprocessorEnvironment> c,
BatchMutateContext context)
+ throws IOException {
Review comment:
This function looks like doPreWithExceptions. Can we refactor and use the
same function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
