swaroopak commented on a change in pull request #499: Phoenix 4703 ALTER INDEX
REBUILD ALL
URL: https://github.com/apache/phoenix/pull/499#discussion_r281460096
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexMetadataIT.java
##########
@@ -610,7 +613,84 @@ public void testAsyncRebuildTimestamp() throws Exception {
"order by table_name" );
assertFalse(rs.next());
}
-
+
+ @Test
+ public void testAsyncRebuildAll() throws Exception {
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ Connection conn = DriverManager.getConnection(getUrl(), props);
Review comment:
I would suggest using try-with-resources for connection and prepareStatement
objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
