gokceni commented on a change in pull request #499: Phoenix 4703 ALTER INDEX
REBUILD ALL
URL: https://github.com/apache/phoenix/pull/499#discussion_r281731558
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/parse/AlterIndexStatement.java
##########
@@ -65,6 +67,10 @@ public boolean isAsync() {
return async;
}
+ public boolean isAll() {
Review comment:
The reason I picked this name is; this class maps directly to Sql statement.
The name of the keyword is ALL. I think it is better if we leave it like this.
ALL can apply to Rebuild or something else in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
