priyankporwal commented on a change in pull request #469: PHOENIX-5156
Consistent Global Indexes for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r282150004
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
##########
@@ -124,6 +125,7 @@ public TableResultIterator(MutationState mutationState,
Scan scan, ScanMetricsHo
this.scanMetricsHolder = scanMetricsHolder;
this.plan = plan;
PTable table = plan.getTableRef().getTable();
+ IndexUtil.setScanAttributes(scan, table,
plan.getContext().getConnection());
Review comment:
Most of the code in this constructor are simple assignments, but this one
stands out with special behavior. It would be good to move it towards the end
(unless it's crucial to invoke it right here) with a comment block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
