[ 
https://issues.apache.org/jira/browse/PHOENIX-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839712#comment-16839712
 ] 

Hadoop QA commented on PHOENIX-5156:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12968691/PHOENIX-5156.master.014.patch
  against master branch at commit 746bf1c275461dc5e6622fc004b74044b7ff1b38.
  ATTACHMENT ID: 12968691

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                                         String dataTableFullName, String 
indexTableFullName) throws SQLException {
+        IndexToolIT.assertExplainPlan(false, actualExplainPlan, 
dataTableFullName, indexTableFullName);
+                " (id varchar(10) not null primary key, val1 varchar(10), val2 
varchar(10), val3 varchar(10))" + tableDDLOptions);
+        conn.createStatement().execute("upsert into " + tableName + " values 
('a', 'ab', 'abc', 'abcd')");
+        conn.createStatement().execute("upsert into " + tableName + " values 
('b', 'bc', 'bcd', 'bcde')");
+        // Configure Indexer to skip the last write phase (i.e., the post 
index update phase) where the verify flag is set
+        // The index rows are actually not deleted yet because Indexer skipped 
delete operation. However, they are
+        // This DML will scan the Index table and detect unverified index 
rows. This will trigger read repair which
+        // result in deleting these rows since the corresponding data table 
rows are deleted already. So, the number of
+        // rows to be deleted by the "DELETE" DML will be zero since the rows 
deleted by read repair will not be visible

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.rpc.PhoenixServerRpcIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RowValueConstructorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsEnabledSplitSystemCatalogIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalIndexCheckerIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2581//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2581//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2581//console

This message is automatically generated.

> Consistent Mutable Global Indexes for Non-Transactional Tables
> --------------------------------------------------------------
>
>                 Key: PHOENIX-5156
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5156
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0, 4.14.0, 5.0.0, 4.14.1
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>         Attachments: PHOENIX-5156.4.x-HBase-1.4.001.patch, 
> PHOENIX-5156.master.001.patch, PHOENIX-5156.master.002.patch, 
> PHOENIX-5156.master.003.patch, PHOENIX-5156.master.004.patch, 
> PHOENIX-5156.master.005.patch, PHOENIX-5156.master.006.patch, 
> PHOENIX-5156.master.007.patch, PHOENIX-5156.master.008.patch, 
> PHOENIX-5156.master.009.patch, PHOENIX-5156.master.010.patch, 
> PHOENIX-5156.master.011.patch, PHOENIX-5156.master.012.patch, 
> PHOENIX-5156.master.013.patch, PHOENIX-5156.master.014.patch
>
>          Time Spent: 21h 50m
>  Remaining Estimate: 0h
>
> Without transactional tables, the mutable global indexes can get easily out 
> of sync with their data tables in Phoenix. Transactional tables require a 
> separate transaction manager, have some restrictions and performance 
> penalties. This issue is to have consistent mutable global indexes without 
> the need for using transactional tables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to