priyankporwal commented on a change in pull request #508: PHOENIX-5283: Add
CASCADE INDEX ALL in the SQL Grammar of ALTER TABLE…
URL: https://github.com/apache/phoenix/pull/508#discussion_r284979986
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
##########
@@ -1420,8 +1420,8 @@ public Long getEstimateInfoTimestamp() throws
SQLException {
private static class ExecutableAddColumnStatement extends
AddColumnStatement implements CompilableStatement {
- ExecutableAddColumnStatement(NamedTableNode table, PTableType
tableType, List<ColumnDef> columnDefs, boolean ifNotExists,
ListMultimap<String,Pair<String,Object>> props) {
- super(table, tableType, columnDefs, ifNotExists, props);
+ ExecutableAddColumnStatement(NamedTableNode table, PTableType
tableType, List<ColumnDef> columnDefs, boolean ifNotExists,
ListMultimap<String,Pair<String,Object>> props, boolean cascade,
List<NamedNode> indexes) {
+ super(table, tableType, columnDefs, ifNotExists, props, cascade,
indexes);
Review comment:
Did you miss 'ALL' here or does it mean that indexes is populated somewhere
with names of all existing indexes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
