[
https://issues.apache.org/jira/browse/PHOENIX-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842996#comment-16842996
]
Hadoop QA commented on PHOENIX-5283:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12969052/PHOENIX-5283.4.x-hbase-1.3.v1.patch
against master branch at commit accd0af195b521cd572219d93033f94ad3b3401e.
ATTACHMENT ID: 12969052
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ ( (DROP COLUMN (IF ex=EXISTS)? c=column_names) | (ADD (cas=CASCADE
INDEX (list=indexes | all=ALL))? (IF NOT ex=EXISTS)? (d=column_defs)
(p=fam_properties)?) | (SET (p=fam_properties)) )
+ { PTableType tt = v==null ?
(QueryConstants.SYSTEM_SCHEMA_NAME.equals(t.getSchemaName()) ?
PTableType.SYSTEM : PTableType.TABLE) : PTableType.VIEW; ret = ( c == null ?
factory.addColumn(factory.namedTable(null,t), tt, d, ex!=null, p, cas!=null,
(all == null ? list : null)) : factory.dropColumn(factory.namedTable(null,t),
tt, c, ex!=null) ); }
+ ExecutableAddColumnStatement(NamedTableNode table, PTableType
tableType, List<ColumnDef> columnDefs, boolean ifNotExists,
ListMultimap<String,Pair<String,Object>> props, boolean cascade,
List<NamedNode> indexes) {
+ public AddColumnStatement addColumn(NamedTableNode table, PTableType
tableType, List<ColumnDef> columnDefs, boolean ifNotExists,
ListMultimap<String,Pair<String,Object>> props, boolean cascade,
List<NamedNode> indexes) {
+ return new ExecutableAddColumnStatement(table, tableType,
columnDefs, ifNotExists, props, cascade, indexes);
+ protected AddColumnStatement(NamedTableNode table, PTableType tableType,
List<ColumnDef> columnDefs, boolean ifNotExists,
ListMultimap<String,Pair<String,Object>> props, boolean cascade,
List<NamedNode> indexes) {
+ public AddColumnStatement addColumn(NamedTableNode table, PTableType
tableType, List<ColumnDef> columnDefs, boolean ifNotExists,
ListMultimap<String,Pair<String,Object>> props, boolean cascade,
List<NamedNode>indexes) {
+ return new AddColumnStatement(table, tableType, columnDefs,
ifNotExists, props, cascade, indexes);
+ true, NamedTableNode.create(statement.getTableName()),
statement.getTableType(),false, null);
+ return addColumn(table, statement.getColumnDefs(),
statement.getProps(), statement.ifNotExists(), false, statement.getTable(),
statement.getTableType(), statement.isCascade(), statement.getIndexes());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2588//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2588//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2588//console
This message is automatically generated.
> Add CASCADE INDEX ALL in the SQL Grammar of ALTER TABLE ADD
> ------------------------------------------------------------
>
> Key: PHOENIX-5283
> URL: https://issues.apache.org/jira/browse/PHOENIX-5283
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-5283.4.x-hbase-1.3.v1.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Include following support in the grammar.
> ALTER TABLE ADD CASCADE <(comma separated list of indexes) | ALL > IF NOT
> EXISTS <COLUMN_NAME> <COLUMN_TYPE>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
