[ 
https://issues.apache.org/jira/browse/PHOENIX-5292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846384#comment-16846384
 ] 

chenglei commented on PHOENIX-5292:
-----------------------------------

[~yanxinyi], thank your for the fix.
a small suggestion: why you did not put {{MathTrigFunctionTest }} under package 
{{org.apache.phoenix.expression.function}} ? In consideration of your 
SinFunction/CosFunction/TanFunction is under package 
{{org.apache.phoenix.expression.function}}, put {{MathTrigFunctionTest }} under 
package {{org.apache.phoenix.expression.function}}  is better?

> fix MathTrigFunctionTest file compile error 
> --------------------------------------------
>
>                 Key: PHOENIX-5292
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5292
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Xinyi Yan
>            Assignee: Xinyi Yan
>            Priority: Minor
>         Attachments: PHOENIX-5292-4.x-HBase-1.4.patch
>
>
> {{MathTrigFunctionTest }}causes compile failed on branch 4.x-HBase-1.3 and 
> 4.x-HBase-1.4, 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to