[ 
https://issues.apache.org/jira/browse/PHOENIX-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848027#comment-16848027
 ] 

Hadoop QA commented on PHOENIX-5300:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12969718/PHOENIX-5300-4.14-HBase-1.4.patch
  against 4.14-HBase-1.4 branch at commit 
0d0efd467871582ce298d15891cce5adf50c92e4.
  ATTACHMENT ID: 12969718

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalMutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2601//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2601//console

This message is automatically generated.

> NoopStatisticsCollector shouldn't scan any rows.
> ------------------------------------------------
>
>                 Key: PHOENIX-5300
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5300
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0, 4.13.1
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>            Priority: Major
>             Fix For: 4.14.2
>
>         Attachments: PHOENIX-5300-4.14-HBase-1.4.patch, 
> PHOENIX-5300-4.14-HBase-1.4.patch
>
>
> Today if we disable calculation of stats via 
> {{phoenix.stats.collection.enabled}} property, it creates 
> {{NoopStatisticsCollector}}. If someone calls "UPDATE STATISTICS 
> <TABLE-NAME>", it will create NoopStatisticsCollector, scan the whole table 
> and does nothing. This is fixed in 4.15 via PHOENIX-4009. If we don't want to 
> backport PHOENIX-4009, we can fix this bug just in 4.14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to